CMake: Remove own FindPython modules, use standard FindPython3 instead
ClosedPublic

Authored by akulichalexandr on Sep 18 2019, 10:19 PM.

Details

Summary

Do not rename PYTHON_EXECUTABLE variable to give a room for Python4 update ๐Ÿ™‚ .

This revision depends on D24065.

Test Plan

Configure and build in a clean environment.

Diff Detail

Repository
R476 Telepathy Logger Qt bindings
Lint
Lint Skipped
Unit
Unit Tests Skipped
akulichalexandr requested review of this revision.Sep 18 2019, 10:19 PM
akulichalexandr created this revision.
akulichalexandr edited the summary of this revision. (Show Details)
apol accepted this revision.Sep 19 2019, 12:53 AM
This revision is now accepted and ready to land.Sep 19 2019, 12:53 AM
heikobecker added inline comments.Sep 19 2019, 6:18 AM
CMakeLists.txt
82

Nothing wrong with that besides that it needs cmake >= 3.12.0, unfortunately...

I think breeze-gtk has a bit of glue code to handle both cmake versions.

Ouch! Thanks, @heikobecker! I think that we can use FindPythonInterp for now.

akulichalexandr updated this revision to Diff 66438.EditedSep 19 2019, 9:55 AM

Use FindPythonInterp on CMake < 3.12

heikobecker added inline comments.Sep 19 2019, 5:02 PM
CMakeLists.txt
88

Wouldn't

find_package(PythonInterp 3)

do the same without the neeed for the stuff in line 88+ ?

akulichalexandr marked an inline comment as done.

Simplify FindPythonInterp invocation.

akulichalexandr marked an inline comment as done.Sep 19 2019, 5:53 PM

Better yet, I forgot REQUIRED option. Probably I was in a rush to address your comment before going to work.
@heikobecker, thank you twice :).

heikobecker accepted this revision.Sep 19 2019, 5:57 PM
This revision was automatically updated to reflect the committed changes.