Handling of aborts during parking/unparking of rolloff roofs corrected
ClosedPublic

Authored by wreissenberger on Sep 18 2019, 8:42 PM.

Details

Summary

Aborting parking and unparking for rolloff roofs led to states where the respective action could not be continued, sinse the buttons were not enabled correctly. This patch fixes this so that parking, unparking, closing and opening of rolloff roofs can be aborted and continued afterwards.

Test Plan

Unpark, park, open or close the roof and abort the respective action. Check, whether it can be continued as expected.

Diff Detail

Repository
R321 KStars
Branch
observatory_rolloff_abort
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16757
Build 16775: arc lint + arc unit
wreissenberger created this revision.Sep 18 2019, 8:42 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptSep 18 2019, 8:42 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
wreissenberger requested review of this revision.Sep 18 2019, 8:42 PM

@yurchor Can you please check the i18n in this patch? I do recall we were advised against using "%1 is foo bar" format before but I'm not sure.

mutlaqja requested changes to this revision.Sep 23 2019, 8:00 AM
mutlaqja added inline comments.
kstars/ekos/observatory/observatory.cpp
225

I think you need i18n around rolloff roof and dome

This revision now requires changes to proceed.Sep 23 2019, 8:00 AM

i18n message for observatory handling corrected

wreissenberger marked an inline comment as done.Sep 24 2019, 7:35 PM

i18n message arguments corrected

mutlaqja requested changes to this revision.Sep 25 2019, 9:10 AM

Great. You need to change the rest of the instances as well.

kstars/ekos/observatory/observatory.cpp
236

This one too.

276

Ditto

291

Same

306

...etc.

This revision now requires changes to proceed.Sep 25 2019, 9:10 AM

i18n arguments corrected (now hopefully complete)

wreissenberger marked 4 inline comments as done.

... and now also in the dome model.

... hopefully the last i18n

mutlaqja accepted this revision.Sep 25 2019, 8:54 PM
This revision is now accepted and ready to land.Sep 25 2019, 8:54 PM
This revision was automatically updated to reflect the committed changes.