Differential D24053

Properly handle ProcessAttribute enabled and default visibility
ClosedPublic
Actions

Authored by ahiemstra on Sep 18 2019, 2:08 PM.

Details

Reviewers

davidedmundson

Group Reviewers

Plasma

Commits

R111:e04aa1b7eebb: Properly handle ProcessAttribute enabled and default visibility

Summary

Rather than enabling them always, use column and application visibility
to determnine if an attribute should be enabled. In addition, use a
new visibleByDefault property to set the default visibility state of
columns.

Test Plan

Start ksysguard, see no plugin provided columns but they can be enabled
from the context menu.

Diff Detail

Repository

R111 KSysguard Library

Branch

plugin_enable

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 16737
Build 16755: arc lint + arc unit

ahiemstra created this revision.Sep 18 2019, 2:08 PM

Restricted Application added a project: Plasma. · View Herald TranscriptSep 18 2019, 2:08 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

ahiemstra requested review of this revision.Sep 18 2019, 2:08 PM

Harbormaster completed remote builds in B16737: Diff 66384.Sep 18 2019, 2:08 PM

ahiemstra mentioned this in D24054: Set default visibility for per-process network sensors to true.Sep 18 2019, 2:16 PM

Thanks!

This revision is now accepted and ready to land.Sep 18 2019, 2:21 PM

ngraham added a dependent revision: D24054: Set default visibility for per-process network sensors to true.Sep 18 2019, 2:51 PM

Closed by commit R111:e04aa1b7eebb: Properly handle ProcessAttribute enabled and default visibility (authored by ahiemstra). · Explain WhySep 19 2019, 10:08 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			processcore/process_attribute.h (8 lines)
M			processcore/process_attribute.cpp (12 lines)
M			processui/ProcessModel.h (7 lines)
M			processui/ProcessModel.cpp (7 lines)
M			processui/ksysguardprocesslist.cpp (38 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	66384	e0e3dd5		Sep 18 2019, 2:08 PM	★	★
Diff 2	66439	8649dd9	R111:e04aa1b7eebb7adde8f8a5695287ddb5f32a6d68	Sep 19 2019, 10:07 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
6b51e14467e4	318420300f97	dd29d45571c4	Arjen Hiemstra	Set ProcessAttribute enable state based on UI conditions (Show More…)	Sep 18 2019, 2:05 PM
dd29d45571c4	d69210163b4b	e0e3dd592d91	Arjen Hiemstra	Add a property to ProcessAttribute if it should be visible by default	Sep 18 2019, 2:01 PM

	Status	Author	Revision
	Closed	ahiemstra	D24054 Set default visibility for per-process network sensors to true
	Closed	ahiemstra	D24053 Properly handle ProcessAttribute enabled and default visibility