Differential D24050

Deploy default avatar via qrc
ClosedPublic
Actions

Authored by nicolasfella on Sep 18 2019, 12:21 PM.

Tags

Subscribers

vkrause, kde-frameworks-devel

Details

Reviewers

Commits

R307:34c324b401d5: Deploy default avatar via qrc

Summary

Needed to have the avatar available on Android

Test Plan

plasma-phonebook on Android now shows default avatar

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

nicolasfella created this revision.Sep 18 2019, 12:21 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptSep 18 2019, 12:21 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

nicolasfella requested review of this revision.Sep 18 2019, 12:21 PM

Harbormaster completed remote builds in B16732: Diff 66375.Sep 18 2019, 12:21 PM

nicolasfella edited the test plan for this revision. (Show Details)Sep 18 2019, 12:22 PM

Approch makes sense in genereal, just minor nitpicks.

CMakeLists.txt
15	This is the default starting at ECM 5.62.
src/resources.qrc
3	I'd namespace the prefix by framework, e.g. org.kde.kpeople.

Remove autorcc
Prefix

Harbormaster completed remote builds in B16735: Diff 66379.Sep 18 2019, 1:17 PM

nicolasfella marked 2 inline comments as done.Sep 18 2019, 1:17 PM

apol accepted this revision.Sep 18 2019, 1:26 PM

This revision is now accepted and ready to land.Sep 18 2019, 1:26 PM

Closed by commit R307:34c324b401d5: Deploy default avatar via qrc (authored by nicolasfella). · Explain WhySep 18 2019, 1:30 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (1 line)
D	M		pixmaps/CMakeLists.txt (1 line)
V			{ → src}/pixmaps/dummy_avatar.png
M			src/CMakeLists.txt (1 line)
M			src/global.h (2 lines)
M			src/global.cpp (5 lines)
M			src/persondata.cpp (2 lines)
M			src/personsmodel.cpp (6 lines)
V			{src ← }/pixmaps/dummy_avatar.png
A	M		src/resources.qrc (6 lines)

Diff 66383

CMakeLists.txt

Loading...

pixmaps/CMakeLists.txt

Loading...

pixmaps/dummy_avatar.png

Loading...

src/CMakeLists.txt

Loading...

src/global.h

Loading...

src/global.cpp

Loading...

src/persondata.cpp

Loading...

src/personsmodel.cpp

Loading...

src/pixmaps/dummy_avatar.png

Loading...

src/resources.qrc

Loading...