Add dummy target for deploying KPeopleVCard on Android
AbandonedPublic
Actions

Authored by nicolasfella on Sep 17 2019, 1:29 PM.

Details

Reviewers

apol
vkrause

Summary

I want to include KPeopleVCard in plasma-phonebook on Android.

The usual way of including plugins via *-android-dependencies.xml fails because kpeoplevcard doesn't have a library which could require the plugin. This patch adds a dummy library target to KPeopleVCard. plasma-phonebook would then link against KF5::PeopleVCardDummy which then tells androiddeployqt to include the kpeoplevcard plugin.

I'm not sure this is the best possible solution, so any suggestions are welcome

Test Plan

Link against KF5::PeopleVCardDummy in plasma-phonebook, libplugins_kpeople_datasource_KPeopleVCard.so is in the APK

Diff Detail

Repository

R732 KPeople VCard Support

Lint

Lint Skipped

Unit

Unit Tests Skipped

nicolasfella requested review of this revision.Sep 17 2019, 1:29 PM

nicolasfella created this revision.

I think the usual way would be to have the android-dependencies.xml file in the library consuming the plugin, which is KPeople here IIUC. In there it would then not be specific for KPeopleVCard.so, but would include everything in plugins/kpeople/*/*.

In D24022#533256, @vkrause wrote:

I think the usual way would be to have the android-dependencies.xml file in the library consuming the plugin, which is KPeople here IIUC. In there it would then not be specific for KPeopleVCard.so, but would include everything in plugins/kpeople/*/*.

That makes an aweful lot of sense

Revision Contents
Changeset List

		Path
M		CMakeLists.txt (2 lines)
M		KF5PeopleVCardConfig.cmake.in (7 lines)
M		src/CMakeLists.txt (13 lines)
A	M	src/KF5PeopleVCardDummy-android-dependencies.xml (4 lines)