Added scripts to create a webfont out of all breeze action icons
ClosedPublic

Authored by fabianr on Sep 17 2019, 7:43 AM.

Details

Summary

Added a grunt task for generating (web)fonts out of the breeze action svg icons

Diff Detail

Repository
R266 Breeze Icons
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16669
Build 16687: arc lint + arc unit
fabianr created this revision.Sep 17 2019, 7:43 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 17 2019, 7:43 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
fabianr requested review of this revision.Sep 17 2019, 7:43 AM
ognarb added a subscriber: ognarb.Sep 17 2019, 7:56 AM
ognarb added inline comments.
webfont/Gruntfile.js
13

why not true?

fabianr added inline comments.Sep 17 2019, 8:06 AM
webfont/Gruntfile.js
13

From
https://www.npmjs.com/package/grunt-webfont

optimize

Type: boolean Default: true

If false the SVGO optimization will not be used. This is useful in cases where the optimizer will produce faulty web fonts by removing relevant SVG paths or attributes.

Since we create a pretty large webfont and some icons are quiet complicated, I set it to false for the moment, to minimize the chance for broken glyphs.

ognarb accepted this revision.Sep 17 2019, 1:05 PM

LGTM

This revision is now accepted and ready to land.Sep 17 2019, 1:05 PM
ndavis accepted this revision.Sep 17 2019, 4:41 PM
fabianr closed this revision.Sep 18 2019, 6:06 AM