[Icons-Only Task Manager] Only show progress indicator for apps that are running
ClosedPublic

Authored by ngraham on Sep 16 2019, 6:01 PM.

Details

Summary

Currently, Pinned Icons-Only Task Manager launchers are capable of showing progress
information even when they're not running, because the app didn't unset the progress
information before quitting, or crashed in the middle of an operation. But the concept
of an in-progress operation for an app that isn't running doesn't make logical sense.

This patch fixes that UI issue by only allowing pinned IOTM apps to show progress
information while they're actually running.

BUG: 409687
FIXED-IN: 5.17.0

Test Plan

Pinned Elisa app no longer shows progress information on its icon after quitting while
playing a song

Pinned Discover app no longer shows progress information on its icon after crashing in
the middle of an update

IOTM apps still shows progress information while running

No change for regular Task Manager

Diff Detail

Repository
R119 Plasma Desktop
Branch
dont-show-progress-indicator-for-non-running-apps (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16647
Build 16665: arc lint + arc unit
ngraham created this revision.Sep 16 2019, 6:01 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 16 2019, 6:01 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Sep 16 2019, 6:01 PM

Technically, it could be updated by a background service but I guess this is more likely got badges. +1
You might want to check for isWindow or something instead?

Yeah I was looking for something simple like task.isRunning but had to settle for checking for a pid in the absence of anything like that. If there's a better way to query for whether or not it's open, I'm all ears.

ngraham updated this revision to Diff 66253.Sep 16 2019, 6:21 PM

Check for task.isWindow instead

ndavis accepted this revision.Sep 17 2019, 4:36 PM
This revision is now accepted and ready to land.Sep 17 2019, 4:36 PM
This revision was automatically updated to reflect the committed changes.