Differential D23971

Build KXmlGui without globalaccel support on Android
ClosedPublic
Actions

Authored by nicolasfella on Sep 15 2019, 3:51 PM.

Details

Reviewers
apol
bcooksley
Commits
R857:a6ce60640216: Build KXmlGui without globalaccel support on Android.
Summary

KGlobalAccel is not useful and blacklisted on Android. This causes Android builds depending on xmlgui to fail because globalaccel is not found

Diff Detail

Repository
R857 CI System Tooling
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella requested review of this revision.Sep 15 2019, 3:51 PM
nicolasfella created this revision.
bcooksley added a comment.Sep 15 2019, 5:28 PM

This looks okay to me - any objections Aleix?

apol accepted this revision.Sep 15 2019, 11:20 PM

I'd write ON, uppercase, it's how it's usually represented.

This revision is now accepted and ready to land.Sep 15 2019, 11:20 PM
nicolasfella added a comment.Sep 17 2019, 10:18 AM

I don't have commit rights for this

bcooksley accepted this revision.Sep 17 2019, 1:07 PM
Closed by commit R857:a6ce60640216: Build KXmlGui without globalaccel support on Android. (authored by nicolasfella, committed by bcooksley). · Explain WhySep 17 2019, 1:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 66295

View Options

build-specs/Frameworks/kxmlgui-AndroidQt5.13.yaml

Loading...