As stated by the clang compiler, when the macro is expanded the not operator is applied only to the left side of the comparison.
Also, the macro in krpreviews.cpp can be deleted because it is not used.
abika |
Krusader |
As stated by the clang compiler, when the macro is expanded the not operator is applied only to the left side of the comparison.
Also, the macro in krpreviews.cpp can be deleted because it is not used.
The only critical point is in KrPreviewJob::slotStartJob(), where !(_job == 0) is not equal to !_job == 0. This method is used to show the file preview instead of the icon.
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
...where !(_job == 0) is not equal to !_job == 0.
Isn't the result always the same?
Replacing 0 by nullptr would also be good. I already did a global replacement with clang-tidy -fix a while ago but this one was missed due to the macro.
Anyway, safe to merge.