KateModeMenuList: add "Best Search Matches" section and fixes for Windows
ClosedPublic

Authored by nibags on Sep 14 2019, 8:25 AM.

Details

Summary

In the syntax highlighting menu, as the items are divided into sections, sometimes the best search match isn't shown first. For example, when writing "c", (in some translations) you have to navigate through the results to select the "C" language.

The Best Search Matches section is added, which shows the best matches at the top of the list. This search section appears only if the exact search matches aren't shown first. For example, when searching for the "C" or "R" language.


I also correct some bugs I saw in Kate for Windows:

  • Don't overlap the scroll bar on the list in Windows, so that the selection of items looks better.
  • The section separator line is semi-transparent in Windows, and the margins are smaller.
  • Avoid always selecting section names.

Diff Detail

Repository
R39 KTextEditor
Branch
modemenu-search
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16499
Build 16517: arc lint + arc unit
nibags created this revision.Sep 14 2019, 8:25 AM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptSep 14 2019, 8:25 AM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
nibags requested review of this revision.Sep 14 2019, 8:25 AM
nibags edited the summary of this revision. (Show Details)Sep 14 2019, 8:28 AM
nibags added reviewers: KTextEditor, cullmann, dhaumann.
cullmann accepted this revision.Sep 14 2019, 8:31 AM

Looks good, thanks for Windows patches.

This revision is now accepted and ready to land.Sep 14 2019, 8:31 AM
nibags closed this revision.Sep 14 2019, 9:33 AM
dhaumann added inline comments.Sep 14 2019, 3:30 PM
src/mode/katemodemenulist.cpp
175

QStringLiteral("") us discouraged and should simply be QString().

nibags marked an inline comment as done.Sep 14 2019, 8:37 PM
nibags added inline comments.
src/mode/katemodemenulist.cpp
175

Fixed in 3aa9c13f5a8b