Add kwayland-integration to kwin dependencies
ClosedPublic

Authored by meven on Sep 13 2019, 3:46 PM.

Details

Summary

When kwayland-integration is not build, krunner and the systray windows appear in the task bar.

Diff Detail

Repository
R499 Metadata for build scripts
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
meven requested review of this revision.Sep 13 2019, 3:46 PM
meven created this revision.
davidedmundson accepted this revision.Sep 13 2019, 3:47 PM
This revision is now accepted and ready to land.Sep 13 2019, 3:47 PM
This revision was automatically updated to reflect the committed changes.
zzag added a subscriber: zzag.Sep 13 2019, 3:57 PM

Code-wise, kwin doesn't need any bit of kwayland-integration.

meven added a comment.Sep 13 2019, 4:27 PM
In D23931#530715, @zzag wrote:

Code-wise, kwin doesn't need any bit of kwayland-integration.

Sure but runtime wise it is needed or testing plasma integration are working well.

Is there any reason why this was only done for stable and not also for the master branch?

meven added a comment.Sep 18 2019, 2:57 PM

Is there any reason why this was only done for stable and not also for the master branch?

As far as I can tell https://phabricator.kde.org/R499:c46b7e5cf44bdbed473751d37256568fb96cceb8 was merged to master.
Did you mean the opposite that we should merge this to the stable branch ?
Also i am bot familiar with this repo, I wonder what the stable branche entails.

There are two files in this repository: dependency-data-kf5-qt5 (which is for the 'master' branch) and dependency-data-stable-kf5-qt5 (which is for the 'stable' branch).
This review only affects the stable file, not the master file.

(This repository is a little confusing I will admit)

meven added a comment.Sep 18 2019, 3:02 PM

Thanks for clarifying. I will make a followup PR for the master branch.