Differential D2393

Don't check current active session at all
Needs RevisionPublic
Actions

Authored by oliverhenshaw on Aug 10 2016, 11:56 AM.

Details

Reviewers
broulik
davidedmundson
Group Reviewers
Plasma
Summary

Simply use cached value so that events processed before we process the
notification that the session is active are treated as if the session is
inactive - as they were likely sent when the session actually was inactive.

Test Plan

Not yet compiled. Impact on consolekit systems not yet investigated.

Diff Detail

Repository
R122 Powerdevil
Lint
Lint Skipped
Unit
Unit Tests Skipped
oliverhenshaw updated this revision to Diff 5801.Aug 10 2016, 11:56 AM
oliverhenshaw retitled this revision from to Don't check current active session at all.
oliverhenshaw updated this object.
oliverhenshaw edited the test plan for this revision. (Show Details)
oliverhenshaw added reviewers: Plasma, broulik.
oliverhenshaw set the repository for this revision to R122 Powerdevil.
oliverhenshaw added a project: Plasma.
oliverhenshaw added a subscriber: plasma-devel.
broulik added inline comments.Aug 10 2016, 12:03 PM
daemon/powerdevilpolicyagent.cpp
426

You still fetch the property, no?

davidedmundson requested changes to this revision.Nov 16 2018, 12:14 PM
davidedmundson added a subscriber: davidedmundson.

Marking as request changes based on Kai's comment which has gone unanswered.

Also you've explained what the patch is doing, but not really what the reason for doing it is.

This revision now requires changes to proceed.Nov 16 2018, 12:14 PM

Revision Contents
Changeset List

PathPackages
Mdaemon/powerdevilpolicyagent.cpp (4 lines)

Diff 5801

View Options

daemon/powerdevilpolicyagent.cpp

Loading...