This avoids having to pass in QPixmaps with a fixed size.
Details
Details
- Reviewers
dfaure - Maniphest Tasks
- T11637: KIconThemes Cleanups
- Commits
- R236:001335535dae: Add QIcon setters for the password dialogs
Diff Detail
Diff Detail
- Repository
- R236 KWidgetsAddons
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 16431 Build 16449: arc lint + arc unit
Comment Actions
Should we deprecate the pixmap methods in favor of the icon ones? Do we need an QIcon getter too?
Comment Actions
A getter would be nice. I am also fine with deprecating the pixmap calls. You can create an icon from a pixmap using QIcon.
(Why is there no setIcon() in QLabel?)
Comment Actions
Add icon() getter, deprecated pixmap methods, remove on demand pixmap label creation as we set an icon unconditionally.