Differential D23903

Remove dead icon loading code
ClosedPublic
Actions

Authored by vkrause on Sep 12 2019, 1:28 PM.

Details

Reviewers
dfaure
davidedmundson
leinir
Maniphest Tasks
T11637: KIconThemes Cleanups
Commits
R304:6e5a8901cb03: Remove dead icon loading code

Diff Detail

Repository
R304 KNewStuff
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16429
Build 16447: arc lint + arc unit
vkrause created this revision.Sep 12 2019, 1:28 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 12 2019, 1:28 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
vkrause requested review of this revision.Sep 12 2019, 1:28 PM
leinir accepted this revision.Sep 12 2019, 1:47 PM
leinir added a subscriber: leinir.

The code is referred to in src/ui/itemsviewdelegate.cpp:322 in a commented-out section, which will likely want to be reimplemented in some other way. However, the code is entirely unused, and i'm fine with this disappearing, that was more a comment for context :)

This revision is now accepted and ready to land.Sep 12 2019, 1:47 PM
Closed by commit R304:6e5a8901cb03: Remove dead icon loading code (authored by vkrause). · Explain WhySep 12 2019, 1:55 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 65911

View Options

src/ui/itemsviewbasedelegate.cpp

Loading...
View Options

src/ui/itemsviewbasedelegate_p.h

Loading...