I think, there isn't need to edit *.ipynb, because they are just an example input data, and also used in tests. So, I think, better revert the .ipynb changes, or update tests content testworksheet.cpp too.

This revision now requires changes to proceed.Sep 11 2019, 6:23 PM

In D23882#529651, @sirgienko wrote:

I think, there isn't need to edit *.ipynb, because they are just an example input data, and also used in tests. So, I think, better revert the .ipynb changes, or update tests content testworksheet.cpp too.

But I fixed src/test/worksheet_test.cpp...

Ok. I will revert the changes.

Remove changes in the tests

Harbormaster completed remote builds in B16397: Diff 65871.Sep 11 2019, 6:33 PM

sirgienko accepted this revision.Sep 11 2019, 7:47 PM

This revision is now accepted and ready to land.Sep 11 2019, 7:47 PM

Closed by commit R55:4f656f9cda17: Fix minor typos (authored by yurchor). · Explain WhySep 11 2019, 7:48 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/backends/maxima/maximaexpression.cpp (2 lines)
M			src/backends/maxima/testmaxima.h (2 lines)
M			src/backends/octave/octavesession.cpp (2 lines)
M			src/backends/octave/testoctave.h (2 lines)
M			src/cantor.cpp (2 lines)
M			src/lib/backend.h (4 lines)
M			src/lib/session.h (2 lines)
M			src/loadedexpression.cpp (2 lines)
M			src/markdownentry.cpp (2 lines)
M			src/mathrender.h (2 lines)
M			src/mathrendertask.cpp (2 lines)
M			src/textentry.cpp (4 lines)
M			src/worksheet.h (2 lines)
M			src/worksheet.cpp (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	65863	7671ac0		Sep 11 2019, 5:22 PM	★	★
Diff 2	65871	7671ac0	Remove changes in the tests	Sep 11 2019, 6:33 PM	★	★
Diff 3	65872	7671ac0	R55:4f656f9cda17f9ad6c2e4c0f66c8f98acdc471d7	Sep 11 2019, 7:48 PM	★	★