Differential D23880

Handle Ctrl+Left/Right not working in brief view
ClosedPublic
Actions

Authored by gengisdave on Sep 11 2019, 4:14 PM.

Details

Reviewers
abika
Group Reviewers
Krusader
Commits
R167:ebb75da3e2c0: Handle Ctrl+Left/Right not working in brief view
Summary

Since the fix for bug 374238, Ctrl key with left or right keys didn't work anymore in the brief view.

This patch change the logic between KrInterBriefView::handleKeyEvent and KrView::handleKeyEvent

FIXED: [ 411384 ] CTRL+RIGHT / CTRL+LEFT
BUG: 411384

Test Plan

Ctrl+Left and Ctrl+Right must change correctly the left or the right panel path (respectively).

Shift+Left and Shift+Right must select all items between the current element and the left or right one.

Left and Right key must navigate left or right instead going to the parent folder or entering into the current folder.

Diff Detail

Repository
R167 Krusader
Lint
Lint Skipped
Unit
Unit Tests Skipped
gengisdave requested review of this revision.Sep 11 2019, 4:14 PM
gengisdave created this revision.
asensi added a subscriber: asensi.Sep 15 2019, 3:35 PM

The new code works using Kubuntu 18.04. Other people can do their checks. Thanks, Davide!

abika accepted this revision.Sep 15 2019, 6:28 PM
abika added a subscriber: abika.

Thanks for fixing the bug i introduces, Davide! Works fine.
These shortcut redirections a damn complicated.

This revision is now accepted and ready to land.Sep 15 2019, 6:28 PM
Closed by commit R167:ebb75da3e2c0: Handle Ctrl+Left/Right not working in brief view (authored by gengisdave). · Explain WhySep 15 2019, 8:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 65855

View Options

krusader/Panel/PanelView/krinterbriefview.cpp

Loading...