[applets/kickoff] Tweak padding for lists
Changes PlannedPublic

Authored by filipf on Wed, Sep 11, 2:41 PM.

Details

Reviewers
ngraham
Group Reviewers
VDG
Plasma
Summary

Add padding on top and at the bottom of lists in Kickoff so the highlight effect doesn't overlap the separator.

Test Plan

Before:

After:

Diff Detail

Repository
R119 Plasma Desktop
Branch
list-padding (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16382
Build 16400: arc lint + arc unit
filipf created this revision.Wed, Sep 11, 2:41 PM
Restricted Application added a project: Plasma. · View Herald TranscriptWed, Sep 11, 2:41 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
filipf requested review of this revision.Wed, Sep 11, 2:41 PM
filipf edited the test plan for this revision. (Show Details)Wed, Sep 11, 2:42 PM
filipf added reviewers: VDG, Plasma, ngraham.

Better, but now the padding is inconsistent between the sides and bottom:

ndavis added a subscriber: ndavis.Wed, Sep 11, 3:02 PM


Look at the top of the view in both screenshots and bottom of the view in the 2nd. Rather than cutting off the content of the items right at the separator as they go out of the visible area, they get cut off early. I think the way they were cut off before was better. I'm guessing that the area around the separator was extended.

ndavis added a comment.EditedWed, Sep 11, 3:10 PM

Better, but now the padding is inconsistent between the sides and bottom:

Are you talking about the margins of the item or the margins of the view? Because it seems like the bottom margin of the item could have also been affected. If you are using a non-Default font or font size, that might be the reason. With Noto Sans 10pt (normal text) and 8pt (small text), the top and bottom margins should be 6px each. In your screenshot, it's 6px on the top and 5px on the bottom. I remember the margins being pretty finicky last time I played with them.

I'm talking about the margins outside the selection highlight effect, which should be equal on the bottom as on the sides. I hadn't even noticed the difference in margins within the selection highlight lol (and yes, I do use non-default fonts and sizes: 11pt Ubuntu font for normal 10pt Ubuntu font for small).

filipf planned changes to this revision.Wed, Sep 11, 10:19 PM

Better, but now the padding is inconsistent between the sides and bottom:

Yeah I think this is the way forward but I don't know where the margins in all the views except Favorites come from. If we add units.largeSpacing in FullRepresentation.qml the top margin is too big in other views.