Differential D23864

test(messageviewerplugins): Adopt changes from ObjectTreeParser
ClosedPublic
Actions

Authored by knauss on Sep 11 2019, 7:43 AM.

Details

Reviewers
dvratil
vkrause
Group Reviewers
KDE PIM
Commits
R81:715578e1c4d0: test(messageviewerplugins): Adopt changes from ObjectTreeParser
Summary

MimeTreeParser::ObjectTreeParser is now completely agnositc of
rendering. That means we have to trigger the rendering step on our own.

Diff Detail

Repository
R81 KDE PIM Addons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
knauss created this revision.Sep 11 2019, 7:43 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptSep 11 2019, 7:43 AM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
knauss requested review of this revision.Sep 11 2019, 7:43 AM
vkrause requested changes to this revision.Sep 11 2019, 7:44 AM
This revision now requires changes to proceed.Sep 11 2019, 7:44 AM
knauss added a comment.Sep 11 2019, 7:52 AM

@vkrause: you requetsted changes to this patch, but don't left any comment? Please speak out, what you have in mind.

vkrause accepted this revision.Sep 11 2019, 8:02 AM
In D23864#529266, @knauss wrote:

@vkrause: you requetsted changes to this patch, but don't left any comment? Please speak out, what you have in mind.

Sorry, misclicked, that was supposed to be an approve.

This revision is now accepted and ready to land.Sep 11 2019, 8:02 AM
Closed by commit R81:715578e1c4d0: test(messageviewerplugins): Adopt changes from ObjectTreeParser (authored by knauss). · Explain WhySep 11 2019, 9:13 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 65833

View Options

CMakeLists.txt

Loading...
View Options

plugins/messageviewer/bodypartformatter/autotests/rendertest-akonadi.cpp

Loading...
View Options

plugins/messageviewer/bodypartformatter/autotests/rendertest.cpp

Loading...
View Options

plugins/messageviewerheaderplugins/autotests/grantleeheaderstyleplugintest.cpp

Loading...