Port away from KHTML
ClosedPublic

Authored by cordlandwehr on Wed, Sep 11, 7:03 AM.

Details

Summary
  • use resources for included HTML files
  • replace KHTML part with QTextBrowser
  • open links to external websites (i.e. Wikipedia) via external web browser
  • remove code for downloading and converting Wikipedia page downloads
  • change all external links to https
  • remove KHTML dependency

Diff Detail

Repository
R341 Step
Branch
feature/portAwayFromKHTML
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16362
Build 16380: arc lint + arc unit
cordlandwehr created this revision.Wed, Sep 11, 7:03 AM
Restricted Application added a project: KDE Edu. · View Herald TranscriptWed, Sep 11, 7:03 AM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
cordlandwehr requested review of this revision.Wed, Sep 11, 7:03 AM

New Layout:


Old Layout:

The visual differences are:

  • now the context information widget is using the same font size as the rest of the application
  • embedded links to external Wikipedia content is opened in an external web browser
yurchor accepted this revision.Wed, Sep 11, 7:14 AM
yurchor added a subscriber: yurchor.

Thanks.

This revision is now accepted and ready to land.Wed, Sep 11, 7:14 AM
vkrause accepted this revision.Wed, Sep 11, 7:40 AM
vkrause added a subscriber: vkrause.

Awesome, thanks!

cordlandwehr closed this revision.Wed, Sep 11, 10:04 AM

Also step/data/Messages.sh needs to be adapted (will do it soon).