Differential D23844

Factor out dataTypes from databaseinterface
ClosedPublic
Actions

Authored by astippich on Sep 10 2019, 6:26 PM.

Tags

Subscribers

None

Details

Reviewers

Commits

R255:c6ac1306793a: Factor out dataTypes from databaseinterface

Summary

Factor out the type definitions from the
databaseinterface so that the database
is not pulled in everywhere

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

astippich requested review of this revision.Sep 10 2019, 6:26 PM

astippich created this revision.

Harbormaster completed remote builds in B16342: Diff 65787.Sep 10 2019, 6:26 PM

fixup

Harbormaster completed remote builds in B16361: Diff 65816.Sep 11 2019, 6:05 AM

rebase

Harbormaster completed remote builds in B16497: Diff 66017.Sep 14 2019, 8:11 AM

Good idea,
sorry for the delay, I had misread the description.

I should really pay more attention to that.

This revision is now accepted and ready to land.Sep 22 2019, 7:21 PM

Closed by commit R255:c6ac1306793a: Factor out dataTypes from databaseinterface (authored by astippich). · Explain WhyOct 6 2019, 11:32 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/alltracksproxymodeltest.cpp (12 lines)
M			autotests/databaseinterfacetest.cpp (29 lines)
M			autotests/datamodeltest.cpp (37 lines)
M			autotests/mediaplaylisttest.cpp (2 lines)
M			autotests/trackmetadatamodeltest.cpp (6 lines)
M			autotests/trackslistenertest.cpp (17 lines)
M			src/CMakeLists.txt (1 line)
M			src/databaseinterface.h (396 lines)
M			src/databaseinterface.cpp (331 lines)
A	M		src/datatypes.h (338 lines)
A	M		src/datatypes.cpp (22 lines)
M			src/elisaapplication.cpp (1 line)
M			src/elisaqmlplugin.cpp (19 lines)
M			src/mediaplaylist.h (18 lines)
M			src/mediaplaylist.cpp (4 lines)
M			src/modeldataloader.h (15 lines)
M			src/models/alltracksproxymodel.cpp (10 lines)
M			src/models/datamodel.h (20 lines)
M			src/models/datamodel.cpp (40 lines)
M			src/models/gridviewproxymodel.cpp (10 lines)
M			src/models/singlealbumproxymodel.cpp (10 lines)
M			src/models/trackcontextmetadatamodel.cpp (14 lines)
M			src/models/trackmetadatamodel.h (10 lines)
M			src/models/trackmetadatamodel.cpp (226 lines)
M			src/musicaudiotrack.h (6 lines)
M			src/musicaudiotrack.cpp (2 lines)
M			src/musiclistenersmanager.h (6 lines)
M			src/musiclistenersmanager.cpp (2 lines)
M			src/trackslistener.h (5 lines)
M			src/trackslistener.cpp (25 lines)
M			src/viewmanager.cpp (6 lines)

Diff 67371

autotests/alltracksproxymodeltest.cpp

Loading...

autotests/databaseinterfacetest.cpp

Loading...

autotests/datamodeltest.cpp

Loading...

autotests/mediaplaylisttest.cpp

Loading...

autotests/trackmetadatamodeltest.cpp

Loading...

autotests/trackslistenertest.cpp

Loading...

src/CMakeLists.txt

Loading...

src/databaseinterface.h

Loading...

src/databaseinterface.cpp

Loading...

src/datatypes.h

Loading...

src/datatypes.cpp

Loading...

src/elisaapplication.cpp

Loading...

src/elisaqmlplugin.cpp

Loading...

src/mediaplaylist.h

Loading...

src/mediaplaylist.cpp

Loading...

src/modeldataloader.h

Loading...

src/models/alltracksproxymodel.cpp

Loading...

src/models/datamodel.h

Loading...

src/models/datamodel.cpp

Loading...

src/models/gridviewproxymodel.cpp

Loading...

src/models/singlealbumproxymodel.cpp

Loading...

src/models/trackcontextmetadatamodel.cpp

Loading...

src/models/trackmetadatamodel.h

Loading...

src/models/trackmetadatamodel.cpp

Loading...

src/musicaudiotrack.h

Loading...

src/musicaudiotrack.cpp

Loading...

src/musiclistenersmanager.h

Loading...

src/musiclistenersmanager.cpp

Loading...

src/trackslistener.h

Loading...

src/trackslistener.cpp

Loading...

src/viewmanager.cpp

Loading...