Enable HiDPI rendering for systemmonitor

Authored by guoyunhe on Sep 10 2019, 3:33 PM.



Make toolbar and menu icons sharp

Diff Detail

R120 Plasma Workspace
No Linters Available
No Unit Test Coverage
Build Status
Buildable 16337
Build 16355: arc lint + arc unit
guoyunhe created this revision.Sep 10 2019, 3:33 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 10 2019, 3:33 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
guoyunhe requested review of this revision.Sep 10 2019, 3:33 PM
ngraham accepted this revision.Sep 10 2019, 3:40 PM
This revision is now accepted and ready to land.Sep 10 2019, 3:40 PM
Closed by commit R120:f62e2f2a0901: Enable HiDPI rendering for systemmonitor (authored by Guo Yunhe <i@guoyunhe.me>). · Explain WhySep 10 2019, 4:13 PM
This revision was automatically updated to reflect the committed changes.

Can you check whether window icons are still correct? See D14490

Does this compile? What compiler are you using? At least it does not on CI: https://build.kde.org/view/Failing/job/Plasma/job/plasma-workspace/

When calling a static method of a class using the "::", one rather needs to use the classname, not the name of an instance of the class. Or use a ".", but that blurs the fact it is a static method, so not recommended.

Please do a fix up :)

kossebau added a comment.EditedSep 10 2019, 5:06 PM

And attributes in general are better set before the application instance is created. Some attributes even need that, so defaulting to it is better,
Also, because someone might change code that is called before the place where the attribute is set, and if that is creating pixmaps already, they will miss out the flag and look broken.