Make toolbar and menu icons sharp
Details
Details
- Reviewers
ngraham - Group Reviewers
Plasma - Commits
- R120:f62e2f2a0901: Enable HiDPI rendering for systemmonitor
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Does this compile? What compiler are you using? At least it does not on CI: https://build.kde.org/view/Failing/job/Plasma/job/plasma-workspace/
When calling a static method of a class using the "::", one rather needs to use the classname, not the name of an instance of the class. Or use a ".", but that blurs the fact it is a static method, so not recommended.
Please do a fix up :)
Comment Actions
And attributes in general are better set before the application instance is created. Some attributes even need that, so defaulting to it is better,
Also, because someone might change code that is called before the place where the attribute is set, and if that is creating pixmaps already, they will miss out the flag and look broken.