Enable HiDPI rendering for systemmonitor
ClosedPublic

Authored by guoyunhe on Tue, Sep 10, 3:33 PM.

Details

Summary

Make toolbar and menu icons sharp

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
guoyunhe created this revision.Tue, Sep 10, 3:33 PM
Restricted Application added a project: Plasma. · View Herald TranscriptTue, Sep 10, 3:33 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
guoyunhe requested review of this revision.Tue, Sep 10, 3:33 PM
ngraham accepted this revision.Tue, Sep 10, 3:40 PM
This revision is now accepted and ready to land.Tue, Sep 10, 3:40 PM
Closed by commit R120:f62e2f2a0901: Enable HiDPI rendering for systemmonitor (authored by Guo Yunhe <i@guoyunhe.me>). · Explain WhyTue, Sep 10, 4:13 PM
This revision was automatically updated to reflect the committed changes.

Can you check whether window icons are still correct? See D14490

Does this compile? What compiler are you using? At least it does not on CI: https://build.kde.org/view/Failing/job/Plasma/job/plasma-workspace/

When calling a static method of a class using the "::", one rather needs to use the classname, not the name of an instance of the class. Or use a ".", but that blurs the fact it is a static method, so not recommended.

Please do a fix up :)

kossebau added a comment.EditedTue, Sep 10, 5:06 PM

And attributes in general are better set before the application instance is created. Some attributes even need that, so defaulting to it is better,
Also, because someone might change code that is called before the place where the attribute is set, and if that is creating pixmaps already, they will miss out the flag and look broken.