| mart |
We have quite a few KCMs that use tabs as top-level components. Since tabs are a bit weird in QML quite a few workarounds have been piling up in some KCMs, making them inconsistent with each other.
By adding a common TabKCM API we can unify the presentation and implementation
Patched plasma-pa KCM:
| No Linters Available |
| No Unit Test Coverage |
| Buildable 16328 | |
| Build 16346: arc lint + arc unit |
Nice, I think we need this.
From the image, I think the frame's background color needs to be the same as the active tab color, and there shouldn't be a line separating them, This is something we currently have in the Plasma-pa KCM (albeit with the wrong background color), but we lose it with this new KCM style.
| src/qmlcontrols/kcmcontrols/qml/TabKCM.qml | ||
|---|---|---|
| 154–161 | FYI, QML has some features from ECMAScript 6, so you could make this code a bit cleaner, e.g. for (const tab of tabs) tab.delegate.createObject(sl, {}); tabsRepeater.model = tabs.map(tab => tab.title); (I didn't test whether this code actually works) | |
Also related: the lack of a real QML tab view: https://bugs.kde.org/show_bug.cgi?id=394296
Achieving this was easier than I initially thought, but now the color of the active tab doesn't match the content. With the line in this was much less of a problem
Can I also suggest making the tabs occupy the full width of the area available (sort of like Kate)? It minimizes the unused space and keeps everything in a nice rectangle:
Can I also suggest making the tabs occupy the full width of the area available (sort of like Kate)? It minimizes the unused space and keeps everything in a nice rectangle:
I kind of like it myself, but if we do this, we'd want to also make the same change for our QWidgets tabs for consistency. Might be better to do that later in subsequent patches.
as background it should probably use a Frame component (which atm in the style is just a simple Rectangle.. si i should fix that and make it draw the proper raised frame;)
also, sadly, it will have to look good-ish also with other styles, like omg, oxygen
Don't use ECMAScript 6 stuff in KDeclarative or plasma-framework! It is a Framework which has a minimum version version support of Qt 5.11 (last three, 5.13, 5.12, 5.11). ECMAScript 6 is only in Qt 5.12