Differential D23834

Add template for Kirigami application development with cmake
AbandonedPublic
Actions

Authored by dkardarakos on Sep 10 2019, 1:39 PM.

Details

Reviewers

apol

Summary

With this commit developers will be able to create a new kirigami application using a template

Test Plan

Create a new project with these steps:
Project > New From Template > Qt > Graphical > Kirigami Application

Diff Detail

Repository

R32 KDevelop

Lint

Lint Skipped

Unit

Unit Tests Skipped

dkardarakos created this revision.Sep 10 2019, 1:39 PM

Restricted Application added a project: KDevelop. · View Herald TranscriptSep 10 2019, 1:39 PM

Restricted Application added a subscriber: kdevelop-devel. · View Herald Transcript

dkardarakos requested review of this revision.Sep 10 2019, 1:39 PM

Nice :)

I would propose though to add this template to the kirigami repo though, so it is also available to people using the kapptemplate tool and using a plain text editor (e.g. Kate).
There is the ECM macro kde_package_app_templates from https://api.kde.org/ecm/kde-module/KDEPackageAppTemplates.html for this purpose.

See e.g. how this is done for templates for Plasma applets & other extensions: https://phabricator.kde.org/source/plasma-framework/browse/master/templates/

Having the template code in the Kirigami repo also improves the chance it gets updated to latest recommended Kirigami code, and people always get the template matching the latest version.

kossebau added inline comments.Sep 10 2019, 2:53 PM

app_templates/cpp/CMake/cmake_kirigami/CMakeLists.txt
11	${ECM_KDE_MODULE_DIR} is part of ${ECM_MODULE_PATH} already, so remove.
18	Best includes these three macros before the others, in this order: include(KDEInstallDirs) include(KDECMakeSettings) include(KDECompilerSettings NO_POLICY_SCOPE) as there purpose is to influence everything else.

Thanks @kossebau for the review. I will create a review request at the kirigami repo.

Revision Contents
Changeset List

			Path
M			app_templates/CMakeLists.txt (1 line)
A	M		app_templates/cpp/CMake/cmake_kirigami/CMakeLists.txt (34 lines)
A	M	(bin)	app_templates/cpp/CMake/cmake_kirigami/cmake-kirigami.png
A	M		app_templates/cpp/CMake/cmake_kirigami/cmake_kirigami.kdevtemplate (8 lines)
A	M		app_templates/cpp/CMake/cmake_kirigami/org.kde.%{APPNAMELC}.appdata.xml (18 lines)
A	M		app_templates/cpp/CMake/cmake_kirigami/org.kde.%{APPNAMELC}.desktop (10 lines)
A	M		app_templates/cpp/CMake/cmake_kirigami/src/CMakeLists.txt (4 lines)
A	M		app_templates/cpp/CMake/cmake_kirigami/src/contents/ui/main.qml (77 lines)
A	M		app_templates/cpp/CMake/cmake_kirigami/src/main.cpp (25 lines)
A	M		app_templates/cpp/CMake/cmake_kirigami/src/resources.qrc (5 lines)