[Notifications] Add "Clear Notifications" context menu entry
ClosedPublic

Authored by broulik on Aug 9 2016, 12:40 PM.

Details

Summary

This adds an entry to clear all notifications in the history.
The entry is only shown if there's actually notifications currently in the history.

BUG: 343686
FIXED-IN: 5.8.0

Test Plan

Ran knotificationdbustest, right-clicked notification item, "Clear Notifications", notification and popup disappeared.

I didn't want to clutter the list too much and adding a button at the end of the list would be difficult to reach.
This is for the people that complain about the "job finished" notifications ;)

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 5772.Aug 9 2016, 12:40 PM
broulik retitled this revision from to [Notifications] Add "Clear Notifications" context menu entry.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Plasma, Plasma: Design, mck182.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma. · View Herald TranscriptAug 9 2016, 12:40 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

Shouldn't that button rather be in the popup itself?

I was thinking about that but where would you want to place it? The only place where it wouldn't look like crap is right of the "Notifications" heading but this is done by system tray and we cannot place items there from within an applet.

davidedmundson accepted this revision.Sep 11 2016, 8:11 PM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.Sep 11 2016, 8:11 PM

This was less of a techincal ping but more of a "should we add this thing now" usability question (see hidden comments above) :)

Okay, let's stick with the context menu for now and see if we can find a good place in the popup at some point.

ordinary I had more often the problem that the notification stuff is empty but I'd like to know what happend in the past.

most of the time I see no new notification but I'd like to see the old ones (5.7.4) maybe 5.8 change this behavior

ordinary I had more often the problem that the notification stuff is empty but I'd like to know what happend in the past.

most of the time I see no new notification but I'd like to see the old ones (5.7.4) maybe 5.8 change this behavior

Why do you want to see them? There is a property for notifications where they can be set to be permanent or not.
Why do you want to see non-permanent notifications from the past? They informed about things which are not relevant anymore, otherwise they would be set as permanent.

This revision was automatically updated to reflect the committed changes.