Split KSslErrorUiData from KTcpSocket
ClosedPublic

Authored by vkrause on Tue, Sep 10, 10:03 AM.

Details

Summary

The former we want to keep, the latter we want to deprecate, so this is
a necessary first step to detangle them.

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Tue, Sep 10, 10:03 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptTue, Sep 10, 10:03 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
vkrause requested review of this revision.Tue, Sep 10, 10:03 AM
aacid added a subscriber: aacid.Tue, Sep 10, 10:17 AM
aacid added inline comments.
src/core/ksslerroruidata.h
27

Minor comment, with all the "noise" around QList in Qt6, would it be maybe more future proof to just #include <QList> ehre so we don't end up declaring a class that doesn't exist in the future?

aacid accepted this revision.Tue, Sep 10, 10:17 AM

Other than that just commit it i'd say, you're just moving code around so no need to "re-review" code that we already accept as "good" for the moment imho

This revision is now accepted and ready to land.Tue, Sep 10, 10:17 AM
This revision was automatically updated to reflect the committed changes.