Port away from Qt's foreach all loops over rvalue container objects
ClosedPublic
Actions

Authored by kossebau on Sep 9 2019, 11:41 PM.

Details

Reviewers

Commits

R263:0cab036a2dab: Port away from Qt's foreach all loops over rvalue container objects

Summary

The other simple part of foreach porting, as those containers objects
are not shared with anyone, so the removal of the container copying has
no risks.

GIT_SILENT

Diff Detail

Repository

R263 KXmlGui

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

kossebau created this revision.Sep 9 2019, 11:41 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptSep 9 2019, 11:41 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

kossebau requested review of this revision.Sep 9 2019, 11:41 PM

Harbormaster completed remote builds in B16296: Diff 65712.Sep 9 2019, 11:41 PM

add some more of this category

Harbormaster completed remote builds in B16297: Diff 65714.Sep 10 2019, 12:35 AM

Thanks!

This revision is now accepted and ready to land.Sep 10 2019, 8:18 AM

Closed by commit R263:0cab036a2dab: Port away from Qt's foreach all loops over rvalue container objects (authored by kossebau). · Explain WhySep 10 2019, 10:34 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/ktoolbar_unittest.cpp (6 lines)
M			src/kedittoolbar.cpp (15 lines)
M			src/kmainwindow.cpp (16 lines)
M			src/kmenumenuhandler_p.cpp (9 lines)
M			src/kshortcutschemeseditor.cpp (6 lines)
M			src/kshortcutschemeshelper.cpp (9 lines)
M			src/kshortcutseditor.cpp (6 lines)
M			src/ktoolbar.cpp (36 lines)
M			src/kxmlguifactory.cpp (3 lines)
M			src/kxmlguiwindow.cpp (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	65712	8673512		Sep 9 2019, 11:41 PM	★	★
Diff 2	65714	8673512	add some more of this category	Sep 10 2019, 12:35 AM	★	★
Diff 3	65734	8673512	R263:0cab036a2dab65250e022af4b45b675626e58ad3	Sep 10 2019, 10:34 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
6c2c8748ec0a	b8521bc971e2	867351258d1f	Friedrich W. H. Kossebau	Port away from Qt's foreach all loops over rvalue container objects (Show More…)	Sep 9 2019, 11:41 PM