Don't create() windows that aren't native, upon receiving a palette change event.
ClosedPublic
Actions

Authored by dfaure on Sep 9 2019, 8:47 PM.

Details

Reviewers

Commits

Test Plan

run kmail or falkon, then run kcmshell5 fonts, change font size

ASSERT: "!d->offscreenWindow->handle()" in file /d/qt/5/kde/qtdeclarative/src/quickwidgets/qquickwidget.cpp, line 1014

Apparently that QQuickWindow should not be create()d so calling winId()
unconditionally here is a bad idea, skip non-native windows.

Repository

R135 Integration for Qt applications in Plasma

Branch

Plasma/5.16

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 16289
Build 16307: arc lint + arc unit

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

dfaure requested review of this revision.Sep 9 2019, 8:47 PM

Makes sense as we install the colour scheme when a window's surface is created.

This revision is now accepted and ready to land.Sep 13 2019, 12:05 PM

			Path	Packages
M			src/platformtheme/x11integration.cpp (2 lines)

Commit	Tree	Parents	Author	Summary	Date
71a5fedd8755	6fd1fc93dbc1	5e467c92ade6	David Faure	Don't create() windows that aren't native, upon receiving a palette change… (Show More…)	Sep 9 2019, 8:40 PM

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	65702	5e467c9		Sep 9 2019, 8:47 PM	★	★