Simple move of tests to the right place
Details
Details
Diff Detail
Diff Detail
- Repository
- R94 PIM: Message Library
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| messageviewer/src/messagepartthemes/default/autotests/objecttreeparsertest.cpp | ||
|---|---|---|
| 39 | Why not move this as well? It does not seem to use anything that is not in the moved tests. Where/how do you draw the line? :) | |
Comment Actions
Thanks for trying out the unified git commit message guideline. :)
Some small notes about the message header: The type should be just test without the s. The subject itself should be start in lower case without period in the end and in imperative, present tense. By that it can also be condensed in size and additional information put into the message:
test(mimetreeparser): move several tests to MimeTreeParser Tests that have no dependency against MessageViewer should be moved to MimeTreeParser. That's simply a move of tests to the right place.
More information at https://github.com/angular/angular/blob/3cf2005a93/CONTRIBUTING.md#-commit-message-guidelines
| messageviewer/src/messagepartthemes/default/autotests/objecttreeparsertest.cpp | ||
|---|---|---|
| 39 | The line is the tests that need rendering and not only the parsing. That is seen, if the output of testWriter is used see line 58/59: QVERIFY(testWriter.data().contains([...])) it is even more obvious with D23807, where we explicitly trigger the rendering step. As you see all reminding tests, trigger rendering. And the rendering is part of MessageViewer, so we can't move those tests to MimeTreeParser. | |