Adds listing of account Shared Drives through the url 'gdrive:/account@gmail.com/Shared Drives/'.
Supported operations:
- Create via 'Create New' -> 'Folder...'
- Delete (if empty)
- Rename
Discussion in T10630: Show Team Drives
Details
Details
- Reviewers
elvisangelaccio - Commits
- R219:41bb6b0214cb: Add Shared Drives to GDriveUrl slave.
Diff Detail
Diff Detail
- Repository
- R219 KIO GDrive
- Branch
- arcpatch-D23804
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 16533 Build 16551: arc lint + arc unit
| src/gdriveurl.cpp | ||
|---|---|---|
| 27 | "Shared Drives" should be translated if possible. | |
| src/kio_gdrive.cpp | ||
| 363 | Q_FOREACH is deprecated, please avoid it in new code. | |
| 376 | Nitpick: opening brace goes to the next line | |
| 383 | const | |
| 388 | Missing pass-by-reference Nitpick: opening brace goes to the next line | |
| 395 | Missing pass-by-reference Nitpick: opening brace goes to the next line | |
| 408 | Redundant comment, info is already in the apidox of runJob. | |
| 412 | Prefer at(0) | |
| 429–433 | Can't we use runJob() here? | |
| 454 | This comment should be just before the if() | |
| 522 | Nitpick: else not needed after return | |
| 683 | Typo: runJob | |
| 1172 | "error() will have been called in case of error" | |
| 1245 | runJob already called error() here, no? | |
| src/kio_gdrive.h | ||
| 90 | const QString &; prefer enum instead of bool as arguments. | |
| src/kio_gdrive.cpp | ||
|---|---|---|
| 429–433 | The desired behavior is silently failing if the user isn't allowed to create shared drives and being that runJob() will always call error(), it isn't used. | |
| src/gdriveurl.cpp | ||
|---|---|---|
| 27 | Sorry, this makes gdriveurl depend on ki18n (e.g. when building urltest). We should call i18n() directly in KIOGDrive::fetchSharedDrivesRootEntry() imho. BTW: does this translation even works? Isn't "Shared Drives" part of the path provided by Google? If we translate it on our side, how can we be sure that Google "understands" our translation? | |
| src/kio_gdrive.cpp | ||
| 32–54 | Please keep the list of includes sorted. | |
| 275 | Missing pass-by-reference | |
| 362 | const | |
| 448 | Nitpick: else after closing brace on previous line | |
Comment Actions
moved translation of Shared Drive label to kio_gdrive.cpp
ordered kio_gdrive.cpp includes
const and ref fixes
| src/gdriveurl.cpp | ||
|---|---|---|
| 27 | I moved the translating to kio_gdrive.cpp, using it only for UDS_DISPLAY_NAME. All operations on Shared Drives are done by id, this string or its path is practically only user facing. | |