Differential D23799

Get rid of khtml usage (kill classic mode)
ClosedPublic
Actions

Authored by svuorela on Sep 9 2019, 2:13 PM.

Details

Reviewers
vkrause
plasma-devel
bcooksley
gladhorn
Group Reviewers
Plasma
Maniphest Tasks
T11542: Remove KHTML
Commits
R124:03892b3b0dc7: Get rid of khtml usage (kill classic mode)
Summary

khtml is going away, so remove the classic mode that relies on it

Test Plan

It's optional, so it can go without much being lost

Diff Detail

Repository
R124 System Settings
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
svuorela created this revision.Sep 9 2019, 2:13 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 9 2019, 2:13 PM
svuorela requested review of this revision.Sep 9 2019, 2:13 PM
GB_2 added a subscriber: GB_2.Sep 9 2019, 2:18 PM

+1, let's also focus on fixing bugs for the other two views.

GB_2 added a reviewer: Plasma.Sep 9 2019, 2:19 PM
GB_2 added a subscriber: Plasma.
ognarb added a subscriber: ognarb.Sep 9 2019, 2:54 PM

+1
is there a task somewhere where we can track all the KDE projects still using khtml?

vkrause added a comment.Sep 10 2019, 8:35 AM
In D23799#527953, @ognarb wrote:

+1
is there a task somewhere where we can track all the KDE projects still using khtml?

T11542 tracks KHTML specifically, and it's part of the larger KF6 workboard for tracking other such legacy dependencies.

davidedmundson added a subscriber: davidedmundson.Sep 10 2019, 9:53 AM

+1 as the new sidebar is very similar IMHO.

gladhorn accepted this revision.Sep 10 2019, 10:58 AM
gladhorn added a subscriber: gladhorn.

Based on all the +1s, this should clearly go in. Go for it :)

This revision is now accepted and ready to land.Sep 10 2019, 10:58 AM
Closed by commit R124:03892b3b0dc7: Get rid of khtml usage (kill classic mode) (authored by svuorela). · Explain WhySep 10 2019, 10:59 AM
This revision was automatically updated to reflect the committed changes.
midenok added a subscriber: midenok.Jan 10 2021, 10:37 AM

Nice job of degradation!

Revision Contents
Changeset List

Diff 65737

View Options

CMakeLists.txt

Loading...
View Options

classic/CMakeLists.txt

Loading...
View Options

classic/CategoryList.h

Loading...
View Options

classic/CategoryList.cpp

Loading...
View Options

classic/ClassicMode.h

Loading...
View Options

classic/ClassicMode.cpp

Loading...
View Options

classic/configClassic.ui

Loading...
View Options

classic/main.html

Loading...
View Options

classic/settings-classic-view.desktop

Loading...
View Options

classic/systemsettings-classic.css

Loading...
View Options

systemsettings.categories

Loading...