[KWidgetAddons] port to non-deprecated Qt API
ClosedPublic
Actions

Authored by dfaure on Sep 9 2019, 1:49 PM.

Details

Reviewers

Commits

Test Plan

Added "cxxflags -DQT_DISABLE_DEPRECATED_BEFORE=0x060000" to
kdesrc-build's kf5-frameworks-build-include (in the frameworks module-set)

Repository

R236 KWidgetsAddons

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 16290
Build 16308: arc lint + arc unit

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

dfaure requested review of this revision.Sep 9 2019, 1:49 PM

+1 looks sane but i have not tried this

src/kcollapsiblegroupbox.cpp
288	if you get bored, add const?
src/kpixmapregionselectordialog.cpp
53	same, if you get bored, const

src/kpopupframe.cpp
23–24	Please keep this sorted.

dhaumann added inline comments.

src/ktitlewidget.cpp
137	Is that not needed anymore?

Lgtm.

src/ktitlewidget.cpp
137	Sorry, the next line gives the answer ;)

constify, sort includes

Merci!

This revision is now accepted and ready to land.Sep 9 2019, 10:28 PM

			Path	Packages
M			autotests/kpasswordlineedittest.cpp (2 lines)
M			autotests/ksqueezedtextlabelautotest.cpp (4 lines)
M			src/kassistantdialog.cpp (2 lines)
M			src/kcapacitybar.cpp (4 lines)
M			src/kcollapsiblegroupbox.cpp (6 lines)
M			src/kcolorbutton.cpp (2 lines)
M			src/kdatecombobox.cpp (2 lines)
M			src/kdatepicker.cpp (2 lines)
M			src/kdatetable.cpp (2 lines)
M			src/kfontchooser.cpp (2 lines)
M			src/kmessagebox.cpp (2 lines)
M			src/kpixmapregionselectordialog.cpp (6 lines)
M			src/kpopupframe.cpp (30 lines)
M			src/kruler.cpp (4 lines)
M			src/kselector.cpp (8 lines)
M			src/ksqueezedtextlabel.cpp (6 lines)
M			src/ktitlewidget.cpp (1 line)
M			src/kxyselector.cpp (7 lines)