Improve API documentation for Definition::setKeywordList()
ClosedPublic

Authored by dhaumann on Sep 7 2019, 12:17 PM.

Details

Summary

Followup to D23061.
The function is described in a bit more general form in addition
with possible risks.

Test Plan

make && make test

Diff Detail

Repository
R216 Syntax Highlighting
Branch
improve-docs
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16211
Build 16229: arc lint + arc unit
dhaumann created this revision.Sep 7 2019, 12:17 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptSep 7 2019, 12:17 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
dhaumann requested review of this revision.Sep 7 2019, 12:17 PM
sirgienko added inline comments.Sep 7 2019, 12:24 PM
src/lib/definition.h
344–348

In general, ... in general

Is it correct? Or just accidental typo?

dhaumann updated this revision to Diff 65571.Sep 7 2019, 12:32 PM
  • Fix duplication of "in general"
dhaumann added inline comments.Sep 7 2019, 12:32 PM
src/lib/definition.h
344–348

Of course not! Thanks!

sirgienko accepted this revision.Sep 7 2019, 12:33 PM
This revision is now accepted and ready to land.Sep 7 2019, 12:33 PM

Thanks for the quick review!

This revision was automatically updated to reflect the committed changes.