Improving Astrometry Conf file support for Linux and OS X
ClosedPublic

Authored by lancaster on Sep 7 2019, 7:37 AM.

Details

Summary

This addresses a number of astrometry issues and adds functionality

  • The Astrometry Conf file option was being ignored on Linux so the user thought they were setting it but were not.
  • The internal conf file option is now available on Linux. For awhile now, KStars on Linux has been using the internal conf file without permission
  • This update allows the conf file editor to now work on Linux too, which adds tons of flexibility.
  • Users can now create multiple directories for conf files wherever they choose
  • Users are now told beforehand and are prevented from downloading files to nonexistant directories and directories that are read only.
  • Users can now specifically choose which directory index files are going into and get a report of what is installed on each
  • Users can also get a report of all index files installed in all directories
  • Adding/changing a directory now in the conf file is easier with a file browser.
  • If there is only one path in conf file, the IndexFileDownloader should behave as before with just the one directory, if there is more than one, then you can select which directory and there is a summary view too.
  • Conf file setup is now consolidated to one file, is more simplified, and is executed earlier and any time its needed.
  • Added a check to make sure that the local conf file and directory are created before running the IndexFileDownloader
  • It checks to see if you really want to download duplicate files
  • It provides folder details now in the file download so the user knows why they can/cannot download to that folder.
  • In the conf file downloader they can now click to open a folder in the List view of the conf file editor.
Test Plan
  • Try creating a new installation on Mac and Linux with no conf file
  • Try adding other directories to the conf file both using the editor and the plus button in the conf file editor
  • Try changing other parameters in the conf file and saving.
  • Try selecting different locations in the index file downloader and downloading/deleting files
  • Try folders that don't actually exist to make sure it lets the user know and prevents the download
  • Try using the Internal Conf file and then try using an external one

Diff Detail

Repository
R321 KStars
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
lancaster created this revision.Sep 7 2019, 7:37 AM
Restricted Application added a project: KDE Edu. · View Herald TranscriptSep 7 2019, 7:37 AM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
lancaster requested review of this revision.Sep 7 2019, 7:37 AM
lancaster updated this revision to Diff 65547.Sep 7 2019, 7:46 AM

Should now be default true on all systems

lancaster edited the summary of this revision. (Show Details)Sep 7 2019, 7:47 AM
lancaster edited the summary of this revision. (Show Details)Sep 7 2019, 7:49 AM
mutlaqja requested changes to this revision.Sep 7 2019, 8:42 AM
mutlaqja added inline comments.
kstars/auxiliary/ksutils.cpp
1426

This now defaults to the internal configuration file on Linux, so if the file does not exist the open file below fails and the user gets a warning about it. The expected behavior is to generate the internal config file without any messages.

1431–1432

Options::astromtryConfFile() is not the same as confPath which leads to more confusion for the user.

kstars/ekos/align/opsastrometryindexfiles.ui
3819

added by mistake?

This revision now requires changes to proceed.Sep 7 2019, 8:42 AM
lancaster updated this revision to Diff 65604.Sep 7 2019, 9:11 PM

Removing unnecessary option, fixing local conf file setup, making conf editor load automatically, and consolidating conf file creation methods to one file.

lancaster edited the summary of this revision. (Show Details)Sep 7 2019, 9:13 PM
lancaster marked 3 inline comments as done.Sep 7 2019, 9:16 PM

The three items should now be fixed

lancaster edited the summary of this revision. (Show Details)Sep 7 2019, 9:25 PM
lancaster updated this revision to Diff 65630.Sep 8 2019, 3:59 AM

Improving interface for config file editor and index file downloader.
Providing details about folder permissions.
Adding dialog to ask if user really wants to download copies of index files

lancaster edited the summary of this revision. (Show Details)Sep 8 2019, 4:01 AM
mutlaqja accepted this revision.Sep 8 2019, 5:55 AM
This revision is now accepted and ready to land.Sep 8 2019, 5:55 AM
This revision was automatically updated to reflect the committed changes.