Make small recent documents icons look like documents and improve clock emblems
ClosedPublic

Authored by ngraham on Sep 6 2019, 10:00 PM.

Diff Detail

Repository
R266 Breeze Icons
Branch
tweak-recent-document-icons (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16191
Build 16209: arc lint + arc unit
ngraham created this revision.Sep 6 2019, 10:00 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 6 2019, 10:00 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ngraham requested review of this revision.Sep 6 2019, 10:00 PM
ngraham retitled this revision from Make recent documents icons look like documents and improve clock emblems to Make small recent documents icons look like documents and improve clock emblems.Sep 6 2019, 10:17 PM
ngraham added a comment.EditedSep 6 2019, 10:25 PM

This is one of those monochrome action icons that happens to have a 24px version. The 24px version also has a small bug: the horizontal line at the bottom goes a bit too far into the area claimed by the clock emblem (or else the vertical line on the right doesn't go down far enough).

I can fix that too, or we could delete the 24px versions for simplicity's sake.

This is one of those monochrome action icons that happens to have a 24px version. The 24px version also has a small bug: the horizontal line at the bottom goes a bit too far into the area claimed by the clock emblem.

I can fix that too, or we could delete the 24px versions for simplicity's sake.

I doubt that there are any programs that use this specific icon at 24px. I should also make a script to automatically create 24px versions of 22px icons though.

While you're at it, we should auto-generate the dark monochrome versions at build-time. There's no good reason to duplicate all of them with only a single difference (changing the text in the stylesheet)

ndavis added a comment.EditedSep 6 2019, 10:29 PM

While you're at it, we should auto-generate the dark monochrome versions at build-time. There's no good reason to duplicate all of them with only a single difference (changing the text in the stylesheet)

Yeah I suppose so. I don't know much about CMake, but it can't be that hard.

ndavis accepted this revision.Sep 6 2019, 10:30 PM
This revision is now accepted and ready to land.Sep 6 2019, 10:30 PM
This revision was automatically updated to reflect the committed changes.
meven added a comment.Sep 7 2019, 9:02 PM

Is that the expected result ?

If so, it needs some polishing IMO.

Is that the expected result ?

If so, it needs some polishing IMO.

In your screenshot, it looks like the 32px version of document-open-recent is used, the removal/visual fixing of which is discussed in D23778.

The folder-open-recent icon appearsto use a smaller size than that, which is inappropriate.