Create new "Recent folders" icon
ClosedPublic

Authored by ngraham on Sep 6 2019, 7:27 PM.

Details

Summary

Needed for D7446.

BUG: 411635
FIXED-IN: 5.62

Test Plan


Diff Detail

Repository
R266 Breeze Icons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Sep 6 2019, 7:27 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 6 2019, 7:27 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ngraham requested review of this revision.Sep 6 2019, 7:27 PM
ndavis requested changes to this revision.Sep 6 2019, 8:34 PM
ndavis added a subscriber: ndavis.

Use this 16px icon. It's more similar to the style of the 22px icon.



Just change color:#232629 to color:#eff0f1 for Breeze Dark.

This revision now requires changes to proceed.Sep 6 2019, 8:34 PM
meven added a comment.Sep 6 2019, 8:43 PM

Also it seems to me the icon is not very similar to


The thickness of the clock pen in particular.
They should be somewhat reminiscent of one another IMHO.

ndavis added a comment.Sep 6 2019, 9:07 PM

Also it seems to me the icon is not very similar to


The thickness of the clock pen in particular.
They should be somewhat reminiscent of one another IMHO.

That's not a 16px icon. This is more comparable:
document-open-recent

The size of that clock is wrong in the first place. Bottom right emblems should typically not be so large that they take up more than 1/4 of the whole icon. However, it is rather difficult to shrink that type of emblem. Readability is a much larger problem with the version I created. I would accept a version with the emblem at 7x7 px, but not the original 8x8 px size.

ngraham updated this revision to Diff 65526.Sep 6 2019, 9:17 PM

Use @ndavis' 16px version

The document icons will also need adjustment to match this style, and also to correct some related visual deficiencies (e.g. the lack of a folded corner). We can do that next.

ndavis accepted this revision.Sep 6 2019, 9:22 PM
This revision is now accepted and ready to land.Sep 6 2019, 9:22 PM
meven added a comment.Sep 6 2019, 9:24 PM

The document icons will also need adjustment to match this style, and also to correct some related visual deficiencies (e.g. the lack of a folded corner). We can do that next.

Great

This revision was automatically updated to reflect the committed changes.
meven added a comment.Oct 15 2019, 2:17 PM

Any plans on updating this icon ?
I think we talked about it but I can't remember the conclusion.

Any plans on updating this icon ?
I think we talked about it but I can't remember the conclusion.

We need to do one of the following:

  • create a monochrome 32px version of folder-open-recent
  • delete the monochrome 32px version of document-open-recent
  • create colorful 32px versions of both per our recent decision that >22px icons should all be colorful

@ndavis, thoughts or preferences?