Differential D23737

Extract mimetype from recentlyused.xbel
ClosedPublic
Actions

Authored by meven on Sep 5 2019, 3:09 PM.

Details

Reviewers
ivan
Commits
R161:3cd9e64d359b: Extract mimetype from recentlyused.xbel
Test Plan

Locally tested

Diff Detail

Repository
R161 KActivity Manager Service
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16139
Build 16157: arc lint + arc unit
meven created this revision.Sep 5 2019, 3:09 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 5 2019, 3:09 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
meven requested review of this revision.Sep 5 2019, 3:09 PM
ivan requested changes to this revision.Sep 5 2019, 3:59 PM
ivan added inline comments.
src/service/plugins/gtk-eventspy/GtkEventSpy.cpp
207

const-ref not const val - const QString& mimetype

This revision now requires changes to proceed.Sep 5 2019, 3:59 PM
meven updated this revision to Diff 65466.Sep 5 2019, 5:52 PM

const QString &mimetype

meven marked an inline comment as done.Sep 5 2019, 5:52 PM
ivan accepted this revision.Sep 5 2019, 5:58 PM
This revision is now accepted and ready to land.Sep 5 2019, 5:58 PM
Closed by commit R161:3cd9e64d359b: Extract mimetype from recentlyused.xbel (authored by meven). · Explain WhySep 5 2019, 6:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 65466

View Options

src/service/plugins/gtk-eventspy/GtkEventSpy.h

Loading...
View Options

src/service/plugins/gtk-eventspy/GtkEventSpy.cpp

Loading...