meven retitled this revision from Add a Term::Type::files() to filter excluding directories to Add Term::Type::files() and Term::Type::locations() to filter excluding or only directories.Sep 5 2019, 8:39 PM

ivan added inline comments.Sep 5 2019, 8:48 PM

src/terms.h
106	Can we call it `directories` to follow the Qt API? That is the only complaint I have, otherwise thie is quite a nice addition.

ngraham added a subscriber: ngraham.Sep 5 2019, 8:55 PM

ngraham added inline comments.

src/terms.h
106	+1, directories is fine for the code, and we can just surface the word "locations" in the UI.

Rename locations to directories

Harbormaster completed remote builds in B16158: Diff 65488.Sep 6 2019, 3:10 AM

meven retitled this revision from Add Term::Type::files() and Term::Type::locations() to filter excluding or only directories to Add Term::Type::files() and Term::Type::directories() to filter only directories or excluding then.Sep 6 2019, 3:10 AM

meven retitled this revision from Add Term::Type::files() and Term::Type::directories() to filter only directories or excluding then to Add Term::Type::files() and Term::Type::directories() to filter only directories or excluding them.

Rename constant LOCATIONS_TYPE_TAG -> DIRECTORIES_TYPE_TAG

Harbormaster completed remote builds in B16159: Diff 65489.Sep 6 2019, 3:12 AM

Rename constant LOCATIONS_TYPE_TAG -> DIRECTORIES_TYPE_TAG bis

Harbormaster completed remote builds in B16160: Diff 65490.Sep 6 2019, 3:14 AM

Spacing

Harbormaster completed remote builds in B16161: Diff 65491.Sep 6 2019, 3:16 AM

ivan accepted this revision.Sep 6 2019, 7:22 AM

This revision is now accepted and ready to land.Sep 6 2019, 7:22 AM

Closed by commit R159:df52b1a382af: Add Term::Type::files() and Term::Type::directories() to filter only… (authored by meven). · Explain WhySep 6 2019, 4:31 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/common/specialvalues.h (2 lines)
M			src/resultset.cpp (6 lines)
M			src/terms.h (8 lines)
M			src/terms.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	65433	99030be		Sep 5 2019, 2:43 PM	★	★
Diff 2	65446	99030be	Exclude files whose mimetype is not known from the files filter	Sep 5 2019, 3:46 PM	★	★
Diff 3	65485	99030be	Add Term::Type::locations	Sep 5 2019, 8:39 PM	★	★
Diff 4	65488	99030be	Rename locations to directories	Sep 6 2019, 3:10 AM	★	★
Diff 5	65489	99030be	Rename constant LOCATIONS_TYPE_TAG -> DIRECTORIES_TYPE_TAG	Sep 6 2019, 3:12 AM	★	★
Diff 6	65490	99030be	Rename constant LOCATIONS_TYPE_TAG -> DIRECTORIES_TYPE_TAG bis	Sep 6 2019, 3:14 AM	★	★
Diff 7	65491	99030be	Spacing	Sep 6 2019, 3:16 AM	★	★
Diff 8	65522	99030be	R159:df52b1a382afe986929b0c2d2c97e65dbf6879e7	Sep 6 2019, 3:43 PM	★	★

Add Term::Type::files() and Term::Type::directories() to filter only directories or excluding them
ClosedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 65485

src/common/specialvalues.h

src/resultset.cpp

src/terms.h

src/terms.cpp

Add Term::Type::files() and Term::Type::directories() to filter only directories or excluding themClosedPublicActions