[kded] Support fractional output scale
ClosedPublic

Authored by romangg on Sep 5 2019, 12:43 PM.

Details

Summary

Read and write fractional output scale values to conifg. We currently round to
one digit.

Diff Detail

Repository
R104 KScreen
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
romangg created this revision.Sep 5 2019, 12:43 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 5 2019, 12:43 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
romangg requested review of this revision.Sep 5 2019, 12:43 PM
cfeck added a subscriber: cfeck.Sep 5 2019, 1:36 PM

I believe 1.25 is a common scale factor. Is something else in the stack limited to one digit?

broulik added a subscriber: broulik.Sep 5 2019, 1:53 PM

I'm pretty sure the startplasma that sets the Qt scaling variables for X also rounds to one digit

I believe 1.25 is a common scale factor. Is something else in the stack limited to one digit?

Current ui only supports one digit. But we can make it two here, so people really needing .25 can set it in the config file. Although I can't believe somebody really needs it when he can also select .2 and .3.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 5 2019, 3:49 PM
This revision was automatically updated to reflect the committed changes.
davidedmundson added inline comments.
kded/output.cpp
357

i don't understand why we need/want this.

KConfig won't corrupt a double through a save/restore.