BUG: 411263
Details
- Reviewers
davidre ngraham - Group Reviewers
Spectacle - Commits
- R166:02f51eb2652f: Save image to clipboard if --nonotify is used
run spectacle with --nonotify
Diff Detail
- Repository
- R166 Spectacle
- Branch
- B411263
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 16123 Build 16141: arc lint + arc unit
Same solution as here:
https://cgit.kde.org/spectacle.git/tree/src/Gui/KSMainWindow.cpp#n399
This also applies the delay of 250 ms when saving the picture not only copying. To make this better we could move this either inside the if-else above or have another test if we copied to clipboard - can't get around a bit of duplication. However this piece of code is all over the place already and I don't like the design of forceNotify and quitting through the main window. So this if fine with me if we could avoid the extra wait when saving to a file.
Changed it to skip if it's not -c -n.
Yeah, I've seen it around. It definitely is not the best solution.. but at least one bug less.
forceNotify is connected to SpectacleCore::doNotify and gets emitted only if notify is true. You mean we need to improve quit() ?
This -> https://cgit.kde.org/spectacle.git/tree/src/Gui/KSMainWindow.cpp#n393