Differential D23705

Use empty/filled style for monochrome empty/full trash
ClosedPublic
Actions

Authored by ndavis on Sep 3 2019, 3:06 PM.

Details

Reviewers
ngraham
Group Reviewers
VDG
Commits
R266:34fe98546fae: Use empty/filled style for monochrome empty/full trash
Summary

We shouldn't rely purely on color to indicate state and red is the wrong color in the first place.

Test Plan

Diff Detail

Repository
R266 Breeze Icons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ndavis created this revision.Sep 3 2019, 3:06 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 3 2019, 3:06 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ndavis requested review of this revision.Sep 3 2019, 3:06 PM
ndavis edited the test plan for this revision. (Show Details)Sep 3 2019, 3:08 PM
ngraham accepted this revision.Sep 3 2019, 3:39 PM
This revision is now accepted and ready to land.Sep 3 2019, 3:39 PM
Closed by commit R266:34fe98546fae: Use empty/filled style for monochrome empty/full trash (authored by ndavis). · Explain WhySep 3 2019, 4:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 65335

View Options

icons-dark/places/16/user-trash-full.svg

Loading...
View Options

icons-dark/places/22/user-trash-full.svg

Loading...
View Options

icons/places/16/user-trash-full.svg

Loading...
View Options

icons/places/22/user-trash-full.svg

Loading...