Differential D23690

[Notifications] Elide application label on the left
ClosedPublic
Actions

Authored by broulik on Sep 3 2019, 8:56 AM.

Details

Reviewers
nicolasfella
Group Reviewers
Plasma
VDG
Commits
R120:6a0df006ec49: [Notifications] Elide application label on the left
Summary

Usually it's not very long, so in the common case of just an application name, it won't be truncated anyway.
But in case an origin is set, it might be. In this case, we want to make sure the end of the origin is shown, in case it is for identifying a website domain.

Test Plan

5.16 please


In the future we could consider splitting the labels so they can be elided independently and adding a tooltip. But for a bugfix release this is fair enough

Suggested by Chromium developer

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Sep 3 2019, 8:56 AM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 3 2019, 8:56 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Sep 3 2019, 8:56 AM
broulik edited the test plan for this revision. (Show Details)Sep 3 2019, 8:58 AM
nicolasfella accepted this revision.Sep 3 2019, 9:35 AM
This revision is now accepted and ready to land.Sep 3 2019, 9:35 AM
Closed by commit R120:6a0df006ec49: [Notifications] Elide application label on the left (authored by broulik). · Explain WhySep 3 2019, 9:49 AM
This revision was automatically updated to reflect the committed changes.
ngraham added a subscriber: ngraham.Sep 3 2019, 1:19 PM

Retroactive +1

Revision Contents
Changeset List

Diff 65301

View Options

applets/notifications/package/contents/ui/NotificationHeader.qml

Loading...