Make user-trash icons look like trashcans
ClosedPublic

Authored by ndavis on Sep 2 2019, 6:48 PM.

Details

Summary

BUG: 399613

Test Plan

Diff Detail

Repository
R266 Breeze Icons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ndavis created this revision.Sep 2 2019, 6:48 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 2 2019, 6:48 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ndavis requested review of this revision.Sep 2 2019, 6:48 PM
ndavis edited the test plan for this revision. (Show Details)Sep 2 2019, 6:51 PM
ndavis updated this revision to Diff 65268.Sep 2 2019, 6:53 PM

Add breeze dark icons

ndavis edited the test plan for this revision. (Show Details)Sep 2 2019, 6:53 PM
ngraham added a subscriber: ngraham.EditedSep 3 2019, 12:52 AM

Yay real trashcans!!!! The appearance is definitely more appropriate compared to before. I really like it.

However I'm afraid the visual recognizability of the full state compared to the empty state is worsened compared to the status quo:

Empty:

Full:

Before, the red folder background made it instantly recognizable that the trash was full--even if this wasn't really an appropriate visual metaphor. I wonder if we could play with other effects to make the full state look more obvious at a glance. Ideas:

  • Tint the can red
  • Add more stuff overflowing from the top, and maybe add some litter on the ground too
  • Color the overflowing stuff red
  • Move the lid that's on the ground so that we're looking at it head-on rather than from the side
  • Make the trashcan itself get fat like the classic mac OS 6 trashcan:

Yay real trashcans!!!! The appearance is definitely more appropriate compared to before. I really like it.

However I'm afraid the visual recognizability of the full state compared to the empty state is worsened compared to the status quo

I agree that it's harder to recognize than before.

Before, the red folder background made it instantly recognizable that the trash was full--even if this wasn't really an appropriate visual metaphor. I wonder if we could play with other effects to make the full state look more obvious at a glance. Ideas:

  • Tint the can red
  • Add more stuff overflowing from the top, and maybe add some litter on the ground to
  • Color the overflowing stuff red
  • Move the lid that's on the ground so that we're looking at it head-on rather than from the side
  • Make the trashcan itself get fat like the classic mac OS 6 trashcan:

I don't want to make the trash can get fat because I think that's ugly, unrealistic and harder to do.

One of my previous ideas was to use a black/dark gray tied up trash bag instead of loose trash, but I don't think that's any easier to recognize and it has contrast issues with Breeze Dark.

https://matrix.org/_matrix/media/r0/download/matrix.org/txuUjBoRPkxqnbEtvqrPNIjL
https://matrix.org/_matrix/media/v1/download/matrix.org/NPVeEfWHbOUXdfwArTclJCiM

I just realized that the full icon is used when the trash has anything in it and not when it's full. Is this intentional?

Before, the red folder background made it instantly recognizable that the trash was full--even if this wasn't really an appropriate visual metaphor. I wonder if we could play with other effects to make the full state look more obvious at a glance. Ideas:

  • Tint the can red
  • Add more stuff overflowing from the top, and maybe add some litter on the ground to
  • Color the overflowing stuff red
  • Move the lid that's on the ground so that we're looking at it head-on rather than from the side
  • Make the trashcan itself get fat like the classic mac OS 6 trashcan:

I don't want to make the trash can get fat because I think that's ugly, unrealistic and harder to do.

All right, let's scratch that. Maybe put a black trashbag on the ground on front of it? And add banana peels and buzzing flies! Make it really obvious that someone needs to take out the trash. :)

I just realized that the full icon is used when the trash has anything in it and not when it's full. Is this intentional?

Yeah. The full state is used when there's anything at all in the trash, not when it's actually full.

ndavis added a comment.EditedSep 3 2019, 1:44 PM

All right, let's scratch that. Maybe put a black trashbag on the ground on front of it? And add banana peels and buzzing flies! Make it really obvious that someone needs to take out the trash. :)

I just realized that the full icon is used when the trash has anything in it and not when it's full. Is this intentional?

Yeah. The full state is used when there's anything at all in the trash, not when it's actually full.

Hm, if that's intended behavior, then I don't think it should be really obvious that the trash needs to be taken out, otherwise it'll just be a constant annoyance. Or worse, it could put some users in the habit of doing +Delete to bypass the trash (I used to do this until I regretted it).

ngraham accepted this revision.Sep 3 2019, 1:48 PM

Actually, that's a great point. The current red appearance is indeed a constant annoyance to me and makes me want to keep it empty all the time, which, now that I think about it, defeats the whole point of the trash.

Let's go with this in its current state.

This revision is now accepted and ready to land.Sep 3 2019, 1:48 PM
ndavis added a comment.Sep 3 2019, 1:54 PM

Actually, that's a great point. The current red appearance is indeed a constant annoyance to me and makes me want to keep it empty all the time, which, now that I think about it, defeats the whole point of the trash.

Let's go with this in its current state.

Do you think I should change the monochrome version as well?

This revision was automatically updated to reflect the committed changes.
This comment was removed by Codezela.