Differential D23676

[Folder View] Only install watch on .directory file if actually used
Needs ReviewPublic
Actions

Authored by broulik on Sep 2 2019, 12:32 PM.

Details

Reviewers
hein
Group Reviewers
Plasma
Summary

Installing a KDirWatch checks file system type to determine which backend to use (e.g. cannot use inotify on NFS), potentially blocking.

Test Plan
  • Folder icon was still correctly shown in the panel
  • Changing the folder icon in Dolphin had the panel icon change live
  • Cascading folder popups no longer install a dir watch when opening

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Sep 2 2019, 12:32 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 2 2019, 12:32 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Sep 2 2019, 12:32 PM

Revision Contents
Changeset List

Diff 65232

View Options

containments/desktop/plugins/folder/foldermodel.h

Loading...
View Options

containments/desktop/plugins/folder/foldermodel.cpp

Loading...