Differential D23675

[Folder View] Don't query file information if tooltips are disabled
ClosedPublic
Actions

Authored by broulik on Sep 2 2019, 12:14 PM.

Details

Reviewers
hein
ngraham
Group Reviewers
Plasma
Commits
R119:b636aa1a9ab3: [Folder View] Don't query file information if tooltips are disabled
Summary

Especially the TypeRole can be quite heavy.

Test Plan

5.17
Disabled tooltips (the default), hovered a slow mount, Plasma didn't freeze anymore.
Enabled tooltips, contents was still correct, and then obviously froze when encountering a slow mount

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Sep 2 2019, 12:14 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 2 2019, 12:14 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Sep 2 2019, 12:14 PM
broulik edited the test plan for this revision. (Show Details)Sep 26 2019, 3:14 PM
ngraham accepted this revision.Sep 26 2019, 7:08 PM
ngraham added a subscriber: ngraham.

Makes logical sense and nothing's broke.

This revision is now accepted and ready to land.Sep 26 2019, 7:08 PM
Closed by commit R119:b636aa1a9ab3: [Folder View] Don't query file information if tooltips are disabled (authored by broulik). · Explain WhySep 27 2019, 7:53 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 66939

View Options

containments/desktop/package/contents/ui/FolderItemDelegate.qml

Loading...