CCBUG: 392882
Details
- Reviewers
ngraham elvisangelaccio - Group Reviewers
Dolphin - Commits
- R318:89a7b316d1a1: [Information Panel] Allows to refresh icon and metadata for urls such as trash:/
- Create a file
- Remove it, so that it goes to the trash
- Open trash
- Empty trash
Before:
Information panel icon is still user-trash-full
After:
Information panel icon is changed to user-trash
Diff Detail
- Repository
- R318 Dolphin
- Branch
- arcpatch-D23668_1
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 18704 Build 18722: arc lint + arc unit
src/panels/information/informationpanel.cpp | ||
---|---|---|
322 | Can you explain what the problem is? Is it because trash:/ is not local? |
src/panels/information/informationpanel.cpp | ||
---|---|---|
322 | Yes indeed, only file:/ and scheme less urls are locals, thrash:/ or recentlyused:/ are not. And this may needed to do this in other knotify slot* in the future. I can add this in comment, if you file it is needed. |
src/panels/information/informationpanel.cpp | ||
---|---|---|
322 | Looking at the git history, this was a KF5 porting bug. KUrl(fileName) was wrongly ported to QUrl::fromLocalFile(), while we should use QUrl::fromUserInput() instead. While at it, we should fix all the occurrences in this file (e.g. slotFilesRemoved() and so on). |
This does depend now on KF5 5.64.
So should I wait for the dependency bump or do it myself ?
https://phabricator.kde.org/D19989#inline-139775 mentions doing also.
It's safest to wait until 5.64 is released (about two weeks) and then commit it alongside a change to bump the dependency version in CMake.