The mime type is passed into the function, so it's already known. Checking mime type inheritance then is quick.
This avoids accessing the file in QFileInfo::isExecutable() potentially blocking just to then realize it's none of the mime types we care about.
Details
Details
Diff Detail
Diff Detail
- Repository
- R241 KIO
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Makes sense.
In D22510 I actually suggested splitting this method into two, but the all-in-one method will still be used by isPromptNeeded, so this can go in.
Comment Actions
will still be used by isPromptNeeded, so this can go in.
Speaking of which, that prompt check should be done after the mimetypejob has finished, not casually blocking everything in synchronous mime type determination beforehand :)