Adding Slew and Sync telescope to top level right click menu
Needs ReviewPublic

Authored by lancaster on Sep 2 2019, 1:59 AM.

Details

Reviewers
mutlaqja
Summary

Adds Slew and Sync Telescope commands right under Center and Track
Changes name of Center and Track
Moves rest of INDI Properties into Submenu.

Diff Detail

Repository
R321 KStars
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15973
Build 15991: arc lint + arc unit
lancaster requested review of this revision.Sep 2 2019, 1:59 AM
lancaster created this revision.
lancaster retitled this revision from Should be fabs not abs, abs is ambiguous. to Adding Slew and Sync telescope to top level right click menu.Sep 2 2019, 2:02 AM
lancaster edited the summary of this revision. (Show Details)
lancaster added a reviewer: mutlaqja.
mutlaqja requested changes to this revision.Sep 2 2019, 4:53 AM
mutlaqja added inline comments.
kstars/fitsviewer/fitslabel.cpp
282

So most people would probably want "Track" and not "Slew" action. Slew is Go to object X, but do not engage tracking.

Track is Slew + engage tracking again once you arrive. Also, are these menu options always there? IMO, they should only be there if there is at least one mount connection.

Also, there should be a way to identify these are "Mount" Slew and "Mount" Sync somehow

Maybe "Slew Telescope" or "Track in Telescope", or "Mount Go to".. same thing for Sync.

kstars/kspopupmenu.cpp
365

We should probably use the new system based on timers than a straight KMessageBox which can block.

This revision now requires changes to proceed.Sep 2 2019, 4:53 AM
lancaster updated this revision to Diff 65196.Sep 2 2019, 6:25 AM

Fixing name problem

lancaster marked an inline comment as done.Sep 2 2019, 6:25 AM

I changed the name as suggested

mutlaqja resigned from this revision.Sep 12 2019, 6:15 AM