Differential D23650

Add an icon for the trash root and a proper label
ClosedPublic
Actions

Authored by meven on Sep 1 2019, 4:03 PM.

Details

Reviewers
ngraham
broulik
Group Reviewers
Frameworks
Commits
R241:a9f8aeb11776: Add an icon for the trash root and a proper label
Summary

BUG: 392882

Test Plan

Diff Detail

Repository
R241 KIO
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15956
Build 15974: arc lint + arc unit
meven created this revision.Sep 1 2019, 4:03 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 1 2019, 4:03 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
meven requested review of this revision.Sep 1 2019, 4:03 PM
meven edited the test plan for this revision. (Show Details)Sep 1 2019, 4:04 PM
broulik added a subscriber: broulik.Sep 1 2019, 4:31 PM
broulik added inline comments.
src/ioslaves/trash/kio_trash.cpp
280

UDS_NAME has to be "." to denote it's the root entry. You want to be adding a UDS_DISPLAY_NAME entry here

meven updated this revision to Diff 65144.Sep 1 2019, 5:11 PM

Notify that trash:/ has changed when emptied, add Display Name

meven marked an inline comment as done.Sep 1 2019, 5:11 PM

I need a fix in dolphin so that the icon in dolphin information panel is updated after the trash is emptied.
Will come soon.

ngraham accepted this revision.Sep 2 2019, 12:10 AM

Nice fix.

This revision is now accepted and ready to land.Sep 2 2019, 12:10 AM
Codezela added a subscriber: Codezela.Sep 2 2019, 7:06 AM

Why trash icon don't look like trash
Like any other os

meven added a comment.Sep 2 2019, 8:02 AM
In D23650#524092, @Codezela wrote:

Why trash icon don't look like trash
Like any other os

This is not related to this patch. Open a design bug if you'd like.

Closed by commit R241:a9f8aeb11776: Add an icon for the trash root and a proper label (authored by meven). · Explain WhySep 2 2019, 8:31 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 65144

View Options

src/ioslaves/trash/kio_trash.cpp

Loading...
View Options

src/ioslaves/trash/trashimpl.cpp

Loading...