feat(mimetreeparser): Support MemoryHole in MimeTreeParser.
ClosedPublic
Actions

Authored by knauss on Sep 1 2019, 3:35 PM.

Details

Reviewers

dvratil
aheinecke

Maniphest Tasks

T742: Add Protected Header support

Commits

R94:80599d7e912f: feat(mimetreeparser): Support MemoryHole in MimeTreeParser.

Summary

The pasring part is done with this patch, but for the user it is not
visible as we need to make sure, that we first create the MimeTree and
afterwards render the header and than the body.

Diff Detail

Repository

R94 PIM: Message Library

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

knauss created this revision.Sep 1 2019, 3:35 PM

Restricted Application added a project: KDE PIM. · View Herald TranscriptSep 1 2019, 3:35 PM

Restricted Application added a subscriber: kde-pim. · View Herald Transcript

knauss requested review of this revision.Sep 1 2019, 3:35 PM

Harbormaster completed remote builds in B15950: Diff 65137.Sep 1 2019, 3:35 PM

knauss added reviewers: dvratil, aheinecke.Sep 10 2019, 9:27 AM

Looks good, mostly small nitpicks.

mimetreeparser/src/messagepart.cpp
1042	Bad indentation
1393	Wrong indentation
mimetreeparser/src/nodehelper.cpp
545–557	This if is not needed, the vector will be allocated automatically by `QMap::operator[]` if it does not exist yet.
mimetreeparser/src/nodehelper.h
85	Should this be called "registerHeaderOverride", since the message part is an override for the "existing" headers (and similarly elsewhere) ?

This revision now requires changes to proceed.Sep 10 2019, 9:03 PM

This revision was not accepted when it landed; it landed in state Needs Revision.Sep 11 2019, 9:02 AM

Closed by commit R94:80599d7e912f: feat(mimetreeparser): Support MemoryHole in MimeTreeParser. (authored by knauss). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			messageviewer/src/header/autotests/grantleeheaderformattertest.cpp (9 lines)
M			messageviewer/src/header/autotests/grantleeheaderstyletest.cpp (3 lines)
M			mimetreeparser/autotests/basicobjecttreeparsertest.h (1 line)
M			mimetreeparser/autotests/basicobjecttreeparsertest.cpp (20 lines)
M			mimetreeparser/src/bodyformatter/applicationpgpencrypted.cpp (2 lines)
M			mimetreeparser/src/bodyformatter/multipartencrypted.cpp (5 lines)
M			mimetreeparser/src/messagepart.h (7 lines)
M			mimetreeparser/src/messagepart.cpp (48 lines)
M			mimetreeparser/src/nodehelper.h (14 lines)
M			mimetreeparser/src/nodehelper.cpp (37 lines)
M			mimetreeparser/src/objecttreeparser.cpp (2 lines)